This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, GCC, AARCH64, 5/6] Enable BTI : Add new pass for BTI.
- From: Sudakshina Das <Sudi dot Das at arm dot com>
- To: James Greenhalgh <James dot Greenhalgh at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, nd <nd at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Thu, 20 Dec 2018 16:40:54 +0000
- Subject: Re: [PATCH, GCC, AARCH64, 5/6] Enable BTI : Add new pass for BTI.
- References: <f99c2918-0d71-271f-6a70-156f8d02486b@arm.com> <520262f0-989a-fa92-5d5f-fa7c90d77198@arm.com> <4a091322-c031-ced1-a78b-dd45316d8c7c@arm.com> <ba3e4346-2bae-c23f-ec53-a3669754c49a@arm.com> <20181219154057.GA21219@arm.com>
Hi James
On 19/12/18 3:40 PM, James Greenhalgh wrote:
> On Fri, Dec 14, 2018 at 10:09:03AM -0600, Sudakshina Das wrote:
>
> <snip>
>
>> I have updated the patch according to our discussions offline.
>> The md pattern is now split into 4 patterns and i have added a new
>> test for the setjmp case along with some comments where missing.
>
> This is OK for trunk.
>
Thanks for the approvals. With this my series is ready to go in trunk. I
will wait for Sam's options patch to go in trunk before I commit mine.
Thanks
Sudi
> Thanks,
> James
>
>> *** gcc/ChangeLog ***
>>
>> 2018-xx-xx Sudakshina Das <sudi.das@arm.com>
>> Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>
>> * config.gcc (aarch64*-*-*): Add aarch64-bti-insert.o.
>> * gcc/config/aarch64/aarch64.h: Update comment for
>> TRAMPOLINE_SIZE.
>> * config/aarch64/aarch64.c (aarch64_asm_trampoline_template):
>> Update if bti is enabled.
>> * config/aarch64/aarch64-bti-insert.c: New file.
>> * config/aarch64/aarch64-passes.def (INSERT_PASS_BEFORE): Insert
>> bti pass.
>> * config/aarch64/aarch64-protos.h (make_pass_insert_bti):
>> Declare the new bti pass.
>> * config/aarch64/aarch64.md (unspecv): Add UNSPECV_BTI_NOARG,
>> UNSPECV_BTI_C, UNSPECV_BTI_J and UNSPECV_BTI_JC.
>> (bti_noarg, bti_j, bti_c, bti_jc): New define_insns.
>> * config/aarch64/t-aarch64: Add rule for aarch64-bti-insert.o.
>>
>> *** gcc/testsuite/ChangeLog ***
>>
>> 2018-xx-xx Sudakshina Das <sudi.das@arm.com>
>>
>> * gcc.target/aarch64/bti-1.c: New test.
>> * gcc.target/aarch64/bti-2.c: New test.
>> * gcc.target/aarch64/bti-3.c: New test.
>> * lib/target-supports.exp
>> (check_effective_target_aarch64_bti_hw): Add new check for
>> BTI hw.
>>
>> Thanks
>> Sudi