This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Use proper print formatter in main function in fixincl.c
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Nicholas Krause <xerofoify at gmail dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 20 Dec 2018 00:20:18 +0000
- Subject: Re: [PATCH] Use proper print formatter in main function in fixincl.c
- References: <20181219233514.13889-1-xerofoify@gmail.com>
This patch is wrong for multiple reasons (the %d you're changing is for an
int argument, so is correct as-is, and %lu is not portable for size_t, so
since we may not be able to assume C99 %zu on the host you'd need to cast
the ttl_data_size argument explicitly to unsigned long int to use %lu for
it).
--
Joseph S. Myers
joseph@codesourcery.com