This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[openacc] Make oacc_fn_attrib_level external
- From: Tom de Vries <tdevries at suse dot de>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Schwinge, Thomas" <Thomas_Schwinge at mentor dot com>
- Date: Wed, 19 Dec 2018 16:28:57 +0100
- Subject: [openacc] Make oacc_fn_attrib_level external
- References: <e2ffbca3-f421-66f6-cca3-e906432ecb15@suse.de> <59bf3552-b97c-6395-6273-0260518b2d15@suse.de>
[ was: Fwd: [openacc, committed] Add oacc_get_default_dim ]
On 19-12-18 16:27, Tom de Vries wrote:
> [ Adding gcc-patches ]
>
> -------- Forwarded Message --------
> Subject: [openacc, committed] Add oacc_get_default_dim
> Date: Wed, 19 Dec 2018 16:24:25 +0100
> From: Tom de Vries <tdevries@suse.de>
> To: Thomas Schwinge <Thomas_Schwinge@mentor.com>
>
> [ was: Re: [nvptx] vector length patch series -- openacc parts ]
>
> On 19-12-18 11:40, Thomas Schwinge wrote:
>> Hi Tom!
>>
>> Thanks for picking up this series!
>>
>>
>> And just to note:
>>
>> On Tue, 18 Dec 2018 00:52:30 +0100, Tom de Vries <tdevries@suse.de> wrote:
>>> On 14-12-18 20:58, Tom de Vries wrote:
>>>
>>>> 0003-openacc-Add-target-hook-TARGET_GOACC_ADJUST_PARALLEL.patch
>>>
>>>> 0017-nvptx-Enable-large-vectors.patch
>>>
>>>> 0023-nvptx-Force-vl32-if-calling-vector-partitionable-rou.patch
>>>
>>> Thomas,
>>>
>>> these patches are openacc (0003) or have openacc components (0017, 0023).
>>>
>>> Can you review and possibly approve the openacc parts?
>>
>> I've seen this (and your earlier questions), and will get to it
>> eventually, thanks.
>>
>>
>
> In that case, let's make the review for the IMO trivial bits post-commit.
>
> Committed the openacc component of 0017 ...
>
... and of 0023.
Thanks,
- Tom
[openacc] Make oacc_fn_attrib_level external
Expose oacc_fn_attrib_level to be used in backends.
2018-12-17 Tom de Vries <tdevries@suse.de>
* omp-offload.c (oacc_fn_attrib_level): Remove static.
* omp-offload.h (oacc_fn_attrib_level): Declare.
---
gcc/omp-offload.c | 2 +-
gcc/omp-offload.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/omp-offload.c b/gcc/omp-offload.c
index 9c7bd7328d1..a220b4b9982 100644
--- a/gcc/omp-offload.c
+++ b/gcc/omp-offload.c
@@ -88,7 +88,7 @@ vec<tree, va_gc> *offload_funcs, *offload_vars;
/* Return level at which oacc routine may spawn a partitioned loop, or
-1 if it is not a routine (i.e. is an offload fn). */
-static int
+int
oacc_fn_attrib_level (tree attr)
{
tree pos = TREE_VALUE (attr);
diff --git a/gcc/omp-offload.h b/gcc/omp-offload.h
index 14edcad8a7d..176c4da7e88 100644
--- a/gcc/omp-offload.h
+++ b/gcc/omp-offload.h
@@ -23,6 +23,7 @@ along with GCC; see the file COPYING3. If not see
#define GCC_OMP_DEVICE_H
extern int oacc_get_default_dim (int dim);
+extern int oacc_fn_attrib_level (tree attr);
extern GTY(()) vec<tree, va_gc> *offload_funcs;
extern GTY(()) vec<tree, va_gc> *offload_vars;