This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] [RFC] PR target/52813 and target/11807
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Dimitar Dimitrov <dimitar at dinux dot eu>
- Cc: Christophe Lyon <christophe dot lyon at linaro dot org>, Thomas Preudhomme <thomas dot preudhomme at linaro dot org>, gcc Patches <gcc-patches at gcc dot gnu dot org>, Richard Sandiford <richard dot sandiford at arm dot com>, "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>
- Date: Mon, 17 Dec 2018 09:23:02 -0600
- Subject: Re: [PATCH] [RFC] PR target/52813 and target/11807
- References: <email@example.com> <3948697.eYaff1WIgU@tpdeb> <20181214085217.GM3803@gate.crashing.org> <53282174.7PqLvzYRYy@tpdeb>
On Sun, Dec 16, 2018 at 10:43:47AM +0200, Dimitar Dimitrov wrote:
> On Fri, Dec 14 2018 2:52:17 EET Segher Boessenkool wrote:
> > You need a few tweaks to what you committed. Or just one perhaps: if
> > flag_pic is not set, you should not check PIC_OFFSET_TABLE_REGNUM, it is
> > meaningless in that case. I'm not sure if you need to check whether the
> > register is fixed or not.
> The flag_pic flag is already checked by the PIC_OFFSET_TABLE_REGNUM macro. It
> will return INVALID_REGNUM if flag_pic is false, so no error will be printed.
No, it is not. On at least six targets the macro is simply defined as a