This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC: libiberty PATCH to disable demangling of ancient mangling schemes
- From: Jason Merrill <jason at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, Pedro Alves <palves at redhat dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Nick Clifton <nickc at redhat dot com>, Ian Lance Taylor <iant at google dot com>, Richard Biener <richard dot guenther at gmail dot com>, matz at gcc dot gnu dot org, Scott Gayou <sgayou at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, Binutils <binutils at sourceware dot org>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 14 Dec 2018 17:39:25 -0500
- Subject: Re: RFC: libiberty PATCH to disable demangling of ancient mangling schemes
- References: <fa1abe9c-7545-6a48-cbf0-97b993345523@redhat.com> <CAFiYyc1gTSXgSiJSFKEWaE0UTGbi45-mWHKJnUb4Wvjp86bbFQ@mail.gmail.com> <460cb971-0e21-1e3e-4920-8b3ee7290cf7@redhat.com> <CAKOQZ8zspME4gzoRw4xgFcShoqeUfp_e=Og=4S-yKn4EehokeA@mail.gmail.com> <736e8303-b724-f96d-54f5-46bff99fa34d@redhat.com> <57d33aa7-4e37-a09c-4bdc-974b5f654d33@redhat.com> <c7c959ca-b8bf-bd3e-a65d-bb274a3118d3@redhat.com> <2928eac9-9363-ddb8-21eb-df878d2d4837@redhat.com> <CADzB+2n6kz=9zLzordWp3gqW+hrLHBhQJ-5p5Lt8Stqv97=nBw@mail.gmail.com> <e720841c-fc62-fef5-559b-442b2a30f776@redhat.com> <20181207104011.GD12380@tucnak> <aff87924-f257-733c-cb6c-0b45dd1a9684@redhat.com> <875zw5cjn9.fsf@tromey.com> <c277ce04-bf3e-45df-e094-953e47da37da@redhat.com>
On Fri, Dec 7, 2018 at 4:00 PM Jason Merrill <jason@redhat.com> wrote:
> On 12/7/18 12:48 PM, Tom Tromey wrote:
> >>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> >
> > Pedro> I would say that it's very, very unlikely, and not worth it of the
> > Pedro> maintenance burden.
> >
> > Agreed, and especially true for the more unusual demanglings like Lucid
> > or EDG.
> >
> > On the gdb side perhaps we can get rid of "demangle-style" now. It
> > probably hasn't worked properly in years, and after this it would be
> > guaranteed not to.
>
> So, here's the patch to tear out the old code, which passes the GCC
> regression testsuite. I also tried building binutils/gdb with it, and
> both will need to remove code that calls cplus_mangle_opname for dealing
> with the old mangling scheme.
GDB/binutils folks, how do you want to handle this? Shall I go ahead
with this patch, with the understanding that there will be associated
changes necessary when merging it into the binutils-gdb repository, or
go with the small disabling patch to start with?
Jason