This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [nvptx] vector length patch series
- From: Tom de Vries <tdevries at suse dot de>
- To: "Schwinge, Thomas" <Thomas_Schwinge at mentor dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 14 Dec 2018 20:58:36 +0100
- Subject: Re: [nvptx] vector length patch series
- References: <d101a77b-fc5f-0396-b8d1-c13f34fd1c38@codesourcery.com> <2ece5d7b-3675-84ab-f255-3c56a2ffd7dc@suse.de> <91b927af-d854-2865-7cbd-9a9a835ab5cc@codesourcery.com>
On 29-10-18 20:28, Cesar Philippidis wrote:
> On 10/5/18 23:22, Tom de Vries wrote:
>> On 9/18/18 10:04 PM, Cesar Philippidis wrote:
>>> 591973d3c3a [nvptx] use user-defined vectors when possible
>>
>> If I drop this patch, I get the same test results. Can you find a
>> testcase for which this patch has an effect?
>
> I just revisited the vector length patch series, and that patch in
> specific is bogus and can be safely dropped.
>
Hi Thomas,
The new vector length patch series contains these patches:
...
0001-libgomp-OpenACC-Adjust-offsets-for-present-data-clau.patch
0002-nvptx-Update-insufficient-launch-message-to-accommod.patch
0003-openacc-Add-target-hook-TARGET_GOACC_ADJUST_PARALLEL.patch
0004-openacc-Make-GFC-default-to-1-for-OpenACC-routine-di.patch
0005-nvptx-update-openacc-dim-macros.patch
0006-nvptx-Rename-worker_bcast-variables-oacc_bcast.patch
0007-nvptx-consolidate-offloaded-function-attributes-into.patch
0008-nvptx-make-nvptx-state-propagation-function-names-mo.patch
0009-nvptx-Fix-whitespace-in-nvptx_single-and-nvptx_neute.patch
0010-nvptx-only-use-one-bar.sync-barriers-in-OpenACC-offl.patch
0011-nvptx-Add-thread-count-parm-to-bar.sync.patch
0012-nvptx-Add-axis_dim.patch
0013-nvptx-Use-TARGET_SET_CURRENT_FUNCTION.patch
0014-nvptx-Use-MAX-MIN-ROUND_UP-macros.patch
0015-nvptx-Generalize-state-propagation-and-synchronizati.patch
0016-nvptx-Add-vector_length-128-testcases.patch
0017-nvptx-Enable-large-vectors.patch
0018-nvptx-Handle-large-vectors-in-libgomp.patch
0019-nvptx-Enable-worker-partitioning-with-warp-sized-vec.patch
0020-nvptx-Simplifly-logic-in-nvptx_single.patch
0021-PR85246-nvptx-Fix-propagation-of-branch-cond-in-vw-n.patch
0022-nvptx-openacc-Don-t-emit-barriers-for-empty-loops.patch
0023-nvptx-Force-vl32-if-calling-vector-partitionable-rou.patch
0024-nvptx-Handle-large-vector-reductions.patch
0025-OpenACC-Enable-firstprivate-OpenACC-reductions.patch
...
> 0001-libgomp-OpenACC-Adjust-offsets-for-present-data-clau.patch
This patch (well, a variant of it) has been committed (although it's not
clear to me why this was included in this patch series).
> 0025-OpenACC-Enable-firstprivate-OpenACC-reductions.patch
This patch is not required for this patch series. If you remove it,
vred2d-128.c and gemm.f90 start to fail, which is trivially fixable by
adding firstprivate clauses according to the test-cases.
> 0004-openacc-Make-GFC-default-to-1-for-OpenACC-routine-di.patch
If I remove this, I run into ICEs in the compiler, but I think that
means we need to understand and fix that ICE, instead of concluding that
we need this patch. It looks completely unrelated.
Thanks,
- Tom
- Follow-Ups:
- [nvptx, committed] Rewrite nvptx_goacc_validate_dims to use predicate vars
- [nvptx, committed] Unify C/Fortran routine handling in nvptx_goacc_validate_dims
- Re: [nvptx] vector length patch series
- [nvptx, committed] Add PTX_WARP_SIZE
- [nvptx, committed] Move macro defs to top of nvptx.c
- [nvptx] vector length patch series -- openacc parts
- [nvptx, committed] Use TARGET_SET_CURRENT_FUNCTION
- [nvptx, committed] Only use one logical barrier resource
- [nvptx, committed] Generalize bar.sync instruction
- [nvptx, committed] Rename worker_bcast variables to oacc_bcast
- [nvptx, committed] Make nvptx state propagation function names more generic
- [nvptx, committed] Use MAX, MIN, ROUND_UP macros
- [nvptx, committed] Add PTX_CTA_SIZE
- Re: [nvptx] vector length patch series