This is the mail archive of the
mailing list for the GCC project.
Re: [committed][testsuite] Remove bashism from libbacktrace/allocfail.sh
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, Ian Lance Taylor <ian at airs dot com>
- Date: Fri, 14 Dec 2018 12:11:50 +0100
- Subject: Re: [committed][testsuite] Remove bashism from libbacktrace/allocfail.sh
- References: <20181214094824.GA6372@delia>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Dec 14, 2018 at 10:48:26AM +0100, Tom de Vries wrote:
> Test-case libbacktrace/allocfail.sh contains bashism "set -o pipefail", which
> makes the script fail on ubuntu 18.04, which links /bin/sh to /bin/dash.
> Fix this by removing the "set -o pipefail".
> Tested by running the test-case with dash on x86_64-linux.
Yeah, the script doesn't contain any |s, so it shouldn't make any difference.
> 2018-12-14 Tom de Vries <email@example.com>
> PR testsuite/88491
> * allocfail.sh: Remove "set -o pipefail".
> libbacktrace/allocfail.sh | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/libbacktrace/allocfail.sh b/libbacktrace/allocfail.sh
> index 91bc7a3e73d..6914de173a3 100755
> --- a/libbacktrace/allocfail.sh
> +++ b/libbacktrace/allocfail.sh
> @@ -32,7 +32,6 @@
> # POSSIBILITY OF SUCH DAMAGE.
> set -e
> -set -o pipefail
> if [ ! -f ./allocfail ]; then
> # Hard failure.