This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed][testsuite] Remove bashism from libbacktrace/allocfail.sh


On Fri, Dec 14, 2018 at 10:48:26AM +0100, Tom de Vries wrote:
> Test-case libbacktrace/allocfail.sh contains bashism "set -o pipefail", which
> makes the script fail on ubuntu 18.04, which links /bin/sh to /bin/dash.
> 
> Fix this by removing the "set -o pipefail".
> 
> Tested by running the test-case with dash on x86_64-linux.

Yeah, the script doesn't contain any |s, so it shouldn't make any difference.

> 2018-12-14  Tom de Vries  <tdevries@suse.de>
> 
> 	PR testsuite/88491
> 	* allocfail.sh: Remove "set -o pipefail".
> 
> ---
>  libbacktrace/allocfail.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libbacktrace/allocfail.sh b/libbacktrace/allocfail.sh
> index 91bc7a3e73d..6914de173a3 100755
> --- a/libbacktrace/allocfail.sh
> +++ b/libbacktrace/allocfail.sh
> @@ -32,7 +32,6 @@
>  # POSSIBILITY OF SUCH DAMAGE.
>  
>  set -e
> -set -o pipefail
>  
>  if [ ! -f ./allocfail ]; then
>      # Hard failure.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]