This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH][libbacktrace] Add allocfail.sh test-case
- From: Tom de Vries <tdevries at suse dot de>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Ian Lance Taylor <ian at airs dot com>
- Date: Wed, 12 Dec 2018 08:03:04 +0100
- Subject: Re: [PATCH][libbacktrace] Add allocfail.sh test-case
- References: <20181128124956.GA4743@delia> <CAKOQZ8yH5iJJFq0UwxPZhtPRp2anLDjGc3Q9-0PTS1=YFkLEpg@mail.gmail.com>
On 11-12-18 18:59, Ian Lance Taylor wrote:
> On Wed, Nov 28, 2018 at 4:50 AM Tom de Vries <firstname.lastname@example.org> wrote:
>> Add test-case that forces alloc.c functions to fail, and check whether fail
>> handling is robust.
>> This is the test-case for "[libbacktrace] Fix segfault upon allocation
>> failure". Without that patch, this test-case fails like this:
>> allocfail.sh: line 71: 26041 Segmentation fault (core dumped) \
>> ./allocfail $i > /dev/null 2>&1
>> Unallowed fail found: 13
>> FAIL allocfail.sh (exit status: 1)
>> This is a seperate patch because the test-case is nontrivial.
>> Bootstrapped and reg-tested on x86_64.
>> OK for trunk?
>> - Tom
>> [libbacktrace] Add allocfail.sh test-case
>> 2018-11-27 Tom de Vries <email@example.com>
>> * Makefile.am (TESTS): Add allocfail.sh.
>> (check_PROGRAMS): Add allocfail.
>> * Makefile.in: Regenerate.
>> * instrumented_alloc.c: New file. Redefine malloc and realloc.
>> Include alloc.c.
>> * allocfail.c: New file.
>> * allocfail.sh: New file.
> Can you redo this without using GNU make features like $(filter-out) ?
Done, and re-bootstrapped-and-regtested.
OK for trunk?