This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [RFC] PR target/52813 and target/11807
- From: Richard Sandiford <richard dot sandiford at arm dot com>
- To: Dimitar Dimitrov <dimitar at dinux dot eu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 10 Dec 2018 11:21:53 +0000
- Subject: Re: [PATCH] [RFC] PR target/52813 and target/11807
- References: <20181209100856.14051-1-dimitar@dinux.eu>
Dimitar Dimitrov <dimitar@dinux.eu> writes:
> I have tested this fix on x86_64 host, and found no regression in the C
> and C++ testsuites. I'm marking this patch as RFC simply because I don't
> have experience with other architectures, and I don't have a setup to
> test all architectures supported by GCC.
>
> gcc/ChangeLog:
>
> 2018-12-07 Dimitar Dimitrov <dimitar@dinux.eu>
>
> * cfgexpand.c (asm_clobber_reg_is_valid): Also produce
> error when stack pointer is clobbered.
> (expand_asm_stmt): Refactor clobber check in separate function.
>
> gcc/testsuite/ChangeLog:
>
> 2018-12-07 Dimitar Dimitrov <dimitar@dinux.eu>
>
> * gcc.target/i386/pr52813.c: New test.
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
LGTM. Do you have a copyright assignment on file? 'Fraid this is
probably big enough to need one.
Thanks,
Richard