This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, OpenACC] Enable GOMP_MAP_FIRSTPRIVATE_INT for OpenACC
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, Cesar Philippidis <cesar at codesourcery dot com>, fortran at gcc dot gnu dot org
- Date: Fri, 7 Dec 2018 15:05:46 +0100
- Subject: Re: [PATCH, OpenACC] Enable GOMP_MAP_FIRSTPRIVATE_INT for OpenACC
- References: <20180920193804.2413efa1@squid.athome> <20181204142712.GY12380@tucnak> <20181206224041.0be7ec2f@squid.athome>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Dec 06, 2018 at 10:40:41PM +0000, Julian Brown wrote:
> + && (TREE_CODE (inner_type) == REAL_TYPE
> + || (!omp_is_reference (var)
> + && INTEGRAL_TYPE_P (inner_type))
> + || TREE_CODE (inner_type) == INTEGER_TYPE)
Not sure I understand the above. INTEGRAL_TYPE_P is INTEGER_TYPE,
BOOLEAN_TYPE and ENUMERAL_TYPE, so you want to handle INTEGER_TYPE
no magger whether var should be passed by reference or not, but BOOLEAN_TYPE
or ENUMERAL_TYPE only if it is not a reference?
That is just weird. Any test to back that up?
> + if ((TREE_CODE (inner_type) == REAL_TYPE
> + || (!omp_is_reference (var)
> + && INTEGRAL_TYPE_P (inner_type))
> + || TREE_CODE (inner_type) == INTEGER_TYPE)
Ditto here.
Jakub