This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH/coding style] clarify pointers and operators
- From: Richard Sandiford <richard dot sandiford at arm dot com>
- To: Martin Sebor <msebor at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Martin Liška <mliska at suse dot cz>
- Date: Wed, 05 Dec 2018 10:04:56 +0000
- Subject: Re: [PATCH/coding style] clarify pointers and operators
- References: <6bce0b3a-0b0d-f03f-5f92-e00156e63629@gmail.com>
Thanks for doing this,
Martin Sebor <msebor@gmail.com> writes:
> Martin suggested we update the Coding Conventions to describe
> the expected style for function declarations with a pointer
> return types, and for overloaded operators. Below is the patch.
>
> As an aside, regarding the space convention in casts: a crude
> grep search yields about 10,000 instances of the "(type)x" kinds
> of casts in GCC sources and 40,000 of the preferred "(type) x"
> style with the space. That's a consistency of only 80%. Is
> it worth documenting a preference for a convention that's so
> inconsistently followed?
Just to be sure, does that grep include things like the go frontend
and its GCC interface, which deliberately don't follow GNU conventions?
A crude grep for me gives 92% consistency in gcc/* itself (excluding
subdirectories), although that's still disappointingly low...
Thanks,
Richard