This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 2/3][rs6000] Fix x86-compat vector intrinsics testcases for BE, 32bit
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Paul Clarke <pc at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 4 Dec 2018 15:34:03 -0600
- Subject: Re: [PATCH 2/3][rs6000] Fix x86-compat vector intrinsics testcases for BE, 32bit
- References: <email@example.com>
On Tue, Dec 04, 2018 at 08:59:40AM -0600, Paul Clarke wrote:
> Fix general endian issues found in the test cases for the compatibility
> implementations of the x86 vector intrinsics. (The tests had been
> inadvertently made to PASS without actually running the test code.
> A later patch fixes this issue.)
> Additionally, a new <smmintrin.h> is added, as some of the APIs therein are
> now used by the test cases. It is _not_ a complete implementation of the
> SSE4 interfaces, only the few "extract" interfaces uses by the tests.
Hrm. We probably should tell the user this file isn't the real thing,
somehow. Could you add a comment in (or near) the header of the file?
I don't think we'll need more, but we'll find out no doubt.
> PR target/88316
> * config/rs6000/smmintrin.h: New file.
> * config.gcc: add smmintrin.h to extra_headers for powerpc*-*-*.
> PR target/88316
> * gcc.target/powerpc/mmx-packssdw-1.c: Fixes for big-endian.
> * gcc.target/powerpc/mmx-packsswb-1.c: Likewise.
> * gcc.target/powerpc/mmx-packuswb-1.c: Likewise.
> * gcc.target/powerpc/mmx-pmulhw-1.c: Likewise.
> * gcc.target/powerpc/sse-cvtpi32x2ps-1.c: Likewise.
> * gcc.target/powerpc/sse-cvtpu16ps-1.c: Likewise.
> * gcc.target/powerpc/sse-cvtss2si-1.c: Likewise.
> * gcc.target/powerpc/sse-cvtss2si-2.c: Likewise.
> * gcc.target/powerpc/sse2-pshufhw-1.c: Likewise.
> * gcc.target/powerpc/sse2-pshuflw-1.c: Likewise.
Okay for trunk with that. Thanks!