This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR fortran/87919 patch for -fno-dec-structure
- From: Fritz Reese <fritzoreese at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: mark dot eggleston at codethink dot co dot uk, fortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
- Date: Mon, 3 Dec 2018 12:39:37 -0500
- Subject: Re: PR fortran/87919 patch for -fno-dec-structure
- References: <686ba917-27d4-451b-a0de-b28074166f2c@codethink.co.uk> <20181107152216.GD11625@tucnak> <CAE4aFA=KCh8fWoXPCNyYouB_N4VvwbKOBUCBiSkFs4EV9j3Tfw@mail.gmail.com> <20181107223230.GI11625@tucnak> <CAE4aFAmGo1v1Xe3z05qnweoJkgJiPZ_aL0=zj7eOiVXwhzOncw@mail.gmail.com> <20181108175357.GR11625@tucnak> <CAE4aFAn_WrFzWco6V5kZJvW19ZgpEqyiGaw8j36n5wX34jW0gA@mail.gmail.com> <72473454-81f8-df39-1cfa-29aa4f93e486@codethink.co.uk> <CAE4aFAmvVvPRUSXDD2qQ7FTcP+9nYKCMveX=Tx2COfdqVs=wzA@mail.gmail.com> <20181203155851.GY12380@tucnak> <20181203171211.GA12380@tucnak>
On Mon, Dec 3, 2018 at 12:12 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Mon, Dec 03, 2018 at 04:58:51PM +0100, Jakub Jelinek wrote:
> > > but I just committed r266745 adjusted for -fdec-include.
> >
> > Thanks, though it seems what you've committed in options.c is incomplete.
> > In the patch you've posted earlier, you've changed also
> > gfc_init_options and gfc_handle_option, to call the new functions
> > (set_init_local_zero, post_dec_options) and use SET_FLAG and undefine it at
> > the end.
> > None of those changes appears in
> > https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/fortran/options.c?limit_changes=0&r1=266745&r2=266744&pathrev=266745
> > all changes stop at the newly added set_init_local_zero, so
> > set_init_local_zero and post_dec_options are now unused functions.
>
> I've committed the remaining options.c changes in r266761 now
> to unbreak the FAILs.
>
> Jakub
Thanks, and sorry...