This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v3] Make function clone name numbering independent.
- From: Michael Ploujnikov <michael dot ploujnikov at oracle dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Richard Guenther <richard dot guenther at gmail dot com>, Martin Jambor <mjambor at suse dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Mon, 3 Dec 2018 12:00:00 -0500
- Subject: Re: [PATCH v3] Make function clone name numbering independent.
- References: <a8a7ea06-98f3-1b7c-d0bb-4e428cb97cf3@oracle.com> <618e046e-3f28-f008-237d-497bcff2531e@oracle.com> <CAFiYyc3fgCkaF0=XvzSDnLoM47a2OgAn0PA8x8Xm3zPJ-D1v-Q@mail.gmail.com> <121c01f4-c1a2-249e-2cac-c6d5ec250fcb@oracle.com> <702ab3f1-fe25-9013-7a1e-f5e1615c9396@oracle.com> <85bd8119-0bce-a06d-df3f-1a1a6ed88187@oracle.com> <CAFiYyc0bF72pX8rr4krbxi6RmKn8VyzKz7VyTEAAeQQJyKXoFQ@mail.gmail.com> <bfd6145a-d8f0-1fa9-5375-77e4e314bcd3@oracle.com> <3167e521-aa5b-e47c-6d9b-956a1af2a886@oracle.com> <078bf036-f02b-3bdb-545d-3f5ad67bc786@oracle.com> <ri636uqlx0q.fsf@suse.cz> <CAFiYyc1dadUexNFtsifE1yUa+oc2np2+Ga2h-XUzmkRkAuzBPg@mail.gmail.com> <ri6y3cik9hf.fsf@suse.cz> <3f9e8c2a-6112-b595-a932-137958e61f5e@oracle.com> <ded14873-6181-849f-6a3e-faf804d3f097@oracle.com> <CAFiYyc0RqvSYCzBpHYwufN4DKMSf9au_NFj2pGjqic7WCefe-A@mail.gmail.com> <fa12f39f-6d95-c3ab-39f9-06481239e234@oracle.com> <CAMe9rOo_JMw6H61K8-T6kHtoOeGeeP5K+Sxpw-a1-pOfRnCyrQ@mail.gmail.com>
On 2018-12-01 11:29 a.m., H.J. Lu wrote:
> This caused:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88297
>
Sorry about that. Looks like I should have been testing with
--with-build-config=bootstrap-lto rather than just --enable-bootstrap.
The quick fix would be to undo the patch to create_virtual_clone or to
just change clone_num_suffixes to key off of DECL_ASSEMBLER_NAME
(node->decl) instead of node pointers. Any preferences?
The harder fix would be to figure out why some nodes share the same
names and fix that, but maybe that's just inevitable with LTO?
- Michael
Attachment:
signature.asc
Description: OpenPGP digital signature