This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING^3] Re: [PATCH 1/3] Support instrumenting returns of instrumented functions
- From: Andi Kleen <andi at firstfloor dot org>
- To: Dominique d'Humières <dominiq at lps dot ens dot fr>
- Cc: andi at firstfloor dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 2 Dec 2018 13:11:29 -0800
- Subject: Re: [PING^3] Re: [PATCH 1/3] Support instrumenting returns of instrumented functions
- References: <E3C52DE1-412B-4190-B883-9903C11C1144@lps.ens.fr>
On Sun, Dec 02, 2018 at 05:26:32PM +0100, Dominique d'Humières wrote:
> Hi Andi,
>
> % gcc9 -S -pg -mfentry -minstrument-return=call -mrecord-return /opt/gcc/work/gcc/testsuite/gcc.target/i386/returninst1.c -m32
> cc1: sorry, unimplemented: -mfentry isn't supported for 32-bit in combination with -fpic
>
> The tests should be protected.
Thanks for the notice.
Here's a patch. Will commit as obvious unless someone objects.
-Andi
diff --git a/gcc/testsuite/gcc.target/i386/returninst1.c b/gcc/testsuite/gcc.target/i386/returninst1.c
index f970e75a774..a0ad155b88d 100644
--- a/gcc/testsuite/gcc.target/i386/returninst1.c
+++ b/gcc/testsuite/gcc.target/i386/returninst1.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target { ! ia32 } } } } */
/* { dg-options "-pg -mfentry -minstrument-return=call -mrecord-return" } */
/* { dg-final { scan-assembler "call.*__return__" } } */
/* { dg-final { scan-assembler "section.*return_loc" } } */
diff --git a/gcc/testsuite/gcc.target/i386/returninst2.c b/gcc/testsuite/gcc.target/i386/returninst2.c
index 716b38556dd..f55218798d8 100644
--- a/gcc/testsuite/gcc.target/i386/returninst2.c
+++ b/gcc/testsuite/gcc.target/i386/returninst2.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target { ! ia32 } } } } */
/* { dg-options "-pg -mfentry -minstrument-return=nop5 -mrecord-return" } */
/* { dg-final { scan-assembler-times "0x0f, 0x1f, 0x44, 0x00, 0x00" 3 } } */
/* { dg-final { scan-assembler "section.*return_loc" } } */
diff --git a/gcc/testsuite/gcc.target/i386/returninst3.c b/gcc/testsuite/gcc.target/i386/returninst3.c
index 5bbc60e8bd4..e0414d338cb 100644
--- a/gcc/testsuite/gcc.target/i386/returninst3.c
+++ b/gcc/testsuite/gcc.target/i386/returninst3.c
@@ -1,4 +1,4 @@
-/* { dg-do compile } */
+/* { dg-do compile { target { ! ia32 } } } } */
/* { dg-options "-pg -mfentry -minstrument-return=call" } */
/* { dg-final { scan-assembler-not "call.*__return__" } } */