This is the mail archive of the
mailing list for the GCC project.
Re: [testsuite] Require ucn support in gdc.test/compilable/ddoc12.d (PR d/88039)
- From: Iain Buclaw <ibuclaw at gdcproject dot org>
- To: ro at cebitec dot uni-bielefeld dot de
- Cc: Mike Stump <mikestump at comcast dot net>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 2 Dec 2018 12:52:08 +0100
- Subject: Re: [testsuite] Require ucn support in gdc.test/compilable/ddoc12.d (PR d/88039)
- References: <yddsgzmkels.fsf@CeBiTec.Uni-Bielefeld.DE> <329A1368-A61A-4FB2-8955-A97589FB1944@comcast.net> <ydd4lc2fha0.fsf@CeBiTec.Uni-Bielefeld.DE> <CABOHX+eKe+OT3sbQtFj_BGOnoX24xjEtYt9kOOzabAB3P4WcqA@mail.gmail.com> <yddy39cdlcd.fsf@CeBiTec.Uni-Bielefeld.DE> <CABOHX+fyx0xR8kRwG8xFkHmC96f3hyeP3R547rZ2LqKtWr9zQg@mail.gmail.com>
On Sat, 1 Dec 2018 at 19:28, Iain Buclaw <email@example.com> wrote:
> On Thu, 29 Nov 2018 at 15:12, Rainer Orth <firstname.lastname@example.org> wrote:
> > Hi Iain,
> > > On Tue, 27 Nov 2018 at 20:32, Rainer Orth <email@example.com> wrote:
> > >>
> > >> Hi Mike,
> > >>
> > >> > On Nov 27, 2018, at 2:18 AM, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
> > >> > wrote:
> > >> >>
> > >> >> Some assemblers, including the Solaris one, don't support UTF-8
> > >> >> identifiers, which breaks the gdc.test/compilable/ddoc12.d testcase as
> > >> >> reported in the PR.
> > >> >
> > >> > So, another style of fix, would be to change the binding from the language
> > >> > front-end to encode unsupported symbols using a fixed, documented, abi
> > >> > defined technique.
> > >>
> > >> there's been some discussion on this in the PR. Joseph's suggestion was
> > >> to follow the system compilers if this were done, and indeed they do
> > >> encode UTF-8 identifiers in some way which could either be
> > >> reverse-engineered or a spec obtained. However, given Iain's stance
> > >> towards UTF-8 identifiers in D, I very much doubt this is worth the
> > >> effort. Ultimately, it's his call, of course.
> > >>
> > >
> > > Not only my stance, but as a whole just how those maintaining the core
> > > language generally agree on. Encoding UTF8 characters in symbols is
> > > not part of the D ABI, so that is something that needs convincing
> > > upstream.
> > >
> > > There is a third way however, all compilable/ddoc* tests don't
> > > actually require us to compile the module all the way down to object
> > > code, the only thing that really needs to be tested is the Ddoc
> > > generator itself. Which would be setting 'dg-do-what compile' and
> > > build with the compiler option -fdoc, then dg-final checks for the
> > > presence of the file ddoc12.html is the minimum that needs to be done
> > > for these tests to be considered passed.
> > >
> > > I'll have a look into doing it that way tomorrow.
> > that would be even better of course, also saving some testing time.
> Hi Rainer,
> Attached patch for it, I've checked that and it does the right thing
> and passes on x86_64.
> There's a couple more changes than just testsuite files, as compiling
> with -fdoc unearthed bug fixes not backported from the D version of
> the compiler. These I'll apply separately.
D2 front-end and testsuite changes have been upstreamed/downstreamed.
If there's no complaint, I'll apply the dejagnu fix as well.