This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Improve combiner's find_split_point (PR target/54589)
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 30 Nov 2018 18:31:25 -0600
- Subject: Re: [PATCH] Improve combiner's find_split_point (PR target/54589)
- References: <20181129214921.GU12380@tucnak> <20181129223601.GO23873@gate.crashing.org>
On Thu, Nov 29, 2018 at 04:36:01PM -0600, Segher Boessenkool wrote:
> Hi Jakub,
> On Thu, Nov 29, 2018 at 10:49:21PM +0100, Jakub Jelinek wrote:
> > The following patch attempts to improve find_split_point inside of
> > complex MEM addresses, if the target supports REG + REG + const
> > addressing, but doesn't support more_complex_rtx + REG + const,
> > try to split it at more_complex_rtx rather than more_complex_rtx + REG.
> > 2018-11-29 Jakub Jelinek <firstname.lastname@example.org>
> > PR target/54589
> > * combine.c (find_split_point): For invalid memory address
> > nonobj + obj + const, if reg + obj + const is valid addressing
> > mode, split at nonobj. Use if rather than else if for the
> > fallback. Comment fixes.
> > * gcc.target/i386/pr54589.c: New test.
> That looks good, but let me try it on some bigger builds first.
Whoops, forgot to get back to you. I tested it, and it looks fine, it
optimises the code quite often :-) Please commit it to trunk.