This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,openacc] Fix infinite recursion in OMP clause pretty-printing, default label
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Cesar Philippidis <cesar at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Tom de Vries <tdevries at suse dot de>
- Date: Fri, 30 Nov 2018 22:40:31 +0100
- Subject: Re: [patch,openacc] Fix infinite recursion in OMP clause pretty-printing, default label
- References: <702b2a15-1cd3-7cb9-ad1b-18fb7517a65b@codesourcery.com> <20181129212047.407a0b79@squid.athome> <alpine.DEB.2.21.1811292123250.27172@digraph.polyomino.org.uk> <20181130213545.2cf83b69@squid.athome>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Nov 30, 2018 at 09:35:45PM +0000, Julian Brown wrote:
> How's this? (Obvious, but re-tested anyway.)
>
> Thanks,
>
> Julian
>
> ChangeLog
>
> gcc/
> * tree-pretty-print.c (dump_omp_clause): Make default case
> gcc_unreachable.
Ok, thanks.
> diff --git a/gcc/tree-pretty-print.c b/gcc/tree-pretty-print.c
> index 99eca4a..0861cc9 100644
> --- a/gcc/tree-pretty-print.c
> +++ b/gcc/tree-pretty-print.c
> @@ -1180,9 +1180,7 @@ dump_omp_clause (pretty_printer *pp, tree clause, int spc, dump_flags_t flags)
> break;
>
> default:
> - /* Should never happen. */
> - dump_generic_node (pp, clause, spc, flags, false);
> - break;
> + gcc_unreachable ();
> }
> }
>
Jakub