Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046

[Peter Bergner <bergner at linux dot ibm dot com>]

On 11/29/18 1:31 PM, Peter Bergner wrote:
> On 11/29/18 11:26 AM, Segher Boessenkool wrote:
>> On Wed, Nov 28, 2018 at 03:27:19PM -0600, Peter Bergner wrote:
>>> PR87496 shows a bug where we ICE if we attempt to use -mabi=ieeelongdouble
>>> and -mno-popcntd.  The IEEE128 support requires full ISA 2.06 (aka POWER7)
>>> support, so we really should throw an error when using those options
>>> together.  Ditto for -mabi=ieeelongdouble and -mno-vsx.  The patch below
>>> does that.
>>>
>>> Ok for mainline once bootstrap and regtesting are complete and clean?
>>
>> Okay.  Eventually we shouldn't allow selecting popcntd independently from
>> -mcpu=, but that day isn't here yet.  So, okay for trunk, and backports
>> if wanted.  Thanks!
> 
> Ok, committed to mainline.  It looks like GCC8 needs the same patch.
> I'll have to look closer at GCC7 on whether it needs it too, since the
> code seems to be a little different.

Ok, both GCC8 and GCC7 need the backport.  I committed the backport
to GCC8 and will do the same for GCC7 once the freeze is over.

Peter