This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH] correct handling of EXCESS_PRECISION_EXPR in function calls (PR 88091)
On 11/28/18 5:05 PM, Martin Sebor wrote:
> On 11/27/18 10:47 AM, Joseph Myers wrote:
>> On Mon, 26 Nov 2018, Martin Sebor wrote:
>>
>>> Ping: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01674.html
>>
>> This patch needs an update to the comment on convert_argument to explain
>> the semantics of the new valtype parameter and how it differs from the
>> previously used TREE_TYPE (val).
>
> I've added comments for all the function arguments.
>
> FWIW, none of these were documented before and I hadn't really
> taken the time to study them all carefully to understand how
> each of them was being used (I just took the undocumented local
> variables and made them arguments). So it took a bit of effort
> to figure out. Hopefully it's close enough.
>
> Martin
>
> gcc-88091.diff
>
> PR c/88091 - c-c++-common/Wconversion-real.c etc. FAIL
>
> gcc/c/ChangeLog:
>
> PR c/88091
> * c-typeck.c (convert_argument): Add a parameter. Adjust indentation.
> (convert_arguments): Add comments. Pass additional argument to
> the function above.
OK.
jeff