This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] target/58397: add host_hooks for NetBSD to make precompiled headers work
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Krister Walfridsson <krister dot walfridsson at gmail dot com>
- Cc: Maya Rashish <coypu at sdf dot org>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 27 Nov 2018 17:00:28 -0500 (EST)
- Subject: Re: [PATCH] target/58397: add host_hooks for NetBSD to make precompiled headers work
- References: <20181125201334.GA12807@SDF.ORG> <Pine.NEB.4.64.1811252341460.2822@gateway.kwa>
Hej!
On Sun, 25 Nov 2018, Krister Walfridsson wrote:
> On Sun, 25 Nov 2018, Maya Rashish wrote:
>
> > gcc/config.host | 4 ++
> > gcc/config/host-netbsd.c | 85 ++++++++++++++++++++++++++++++++++++++++
> > gcc/config/x-netbsd | 4 ++
> > 3 files changed, 93 insertions(+)
> > create mode 100644 gcc/config/host-netbsd.c
> > create mode 100644 gcc/config/x-netbsd
>
> I started a new job a wile back, and my paper work is currently not in order.
> So I do not think I am allowed to approve patches now... :(
Ackchyually...
You're right to be cautious about these matters of course, but
to avoid this leading to any kind of precedent, I'll just say
that in my book approving != submitting or committing.
IOW, I wouldn't hesitate to (only) *review* and *approve*
patches that are otherwise in good standing regarding paperwork
(though I don't know if that's the case here), if I had changed
jobs thereby voiding my filed FSF paperwork.
brgds, H-P