This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix -fstack-protector* on darwin/mingw etc. (PR target/85644)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 21 Nov 2018 23:25:55 +0100
- Subject: Re: [PATCH] Fix -fstack-protector* on darwin/mingw etc. (PR target/85644)
- References: <20181121222118.GX11625@tucnak>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Nov 21, 2018 at 11:21:18PM +0100, Jakub Jelinek wrote:
> As I wrote in the PR, before PR81708 commits,
Note, e.g. in 4.8, the stack_protector_* patterns weren't guarded with
something like TARGET_SSP_TLS_GUARD but with !TARGET_HAS_BIONIC,
which just means it was incorrectly implemented for Android initially
(should have been done by forcing there the non-*tls* insns for
!TARGET_HAS_BIONIC rather than failing the optab).
Jakub