This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

From: Joseph Myers <joseph at codesourcery dot com>
To: David Malcolm <dmalcolm at redhat dot com>
Cc: Jason Merrill <jason at redhat dot com>, Martin Sebor <msebor at gmail dot com>, Eric Gallager <egall at gwmail dot gwu dot edu>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Tue, 20 Nov 2018 22:23:12 +0000
Subject: Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)
References: <CADzB+2nMUVXThn=8_CeurHmCo2Rckqy+37RuEYBSFNqsCkY20Q@mail.gmail.com> <1542662581-41571-1-git-send-email-dmalcolm@redhat.com> <alpine.DEB.2.21.1811200243080.10031@digraph.polyomino.org.uk> <1542751554.4619.83.camel@redhat.com>

On Tue, 20 Nov 2018, David Malcolm wrote:

> Should I do:

You should do whatever is appropriate for the warning in question.  But if 
what's appropriate for the warning in question includes types that are 
compatible but not the same, the comments need to avoid saying it's about 
the types being the same.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- [PATCH] v4: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)
  - From: David Malcolm

References:
- Re: [PATCH] v2: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)
  - From: Jason Merrill
- [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)
  - From: David Malcolm
- Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)
  - From: Joseph Myers
- Re: [PATCH] v3: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)
  - From: David Malcolm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]