This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][LRA] Fix PR88033: ICE in remove_some_program_points_and_update_live_ranges


On 11/19/18 1:17 PM, Vladimir Makarov wrote:
> On 11/16/2018 02:15 PM, Peter Bergner wrote:
>> PR88033 shows a problem when handling simple copies from a register to itself:
>>
>>    (insn (set (reg:DI NNN) (reg:DI NNN)))
>>
>> This was causing confusion in the code that performs liveness and conflict
>> updates and program point updates in lra-lives.c.  Trying to handle these
>> types of copies would add some ugly code.  It's easier to just bail on them
>> in non_conflicting_reg_copy_p() altogether, since by definition, a register
>> does not conflict with itself and so needs no special handling.  The patch
>> below implements that and fixes the ICE.
>>
>> This is currently bootstrapping and regtesting on x86_64-linux.
>> Ok for mainline assuming the tests show no regressions?
>>
> OK.  Thank you, Peter.

Thanks, this is now committed.

Peter


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]