This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH PR84648]Adjust loop exit conditions for loop-until-wrap cases.

From: "Bin.Cheng" <amker dot cheng at gmail dot com>
To: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
Cc: bin dot cheng at linux dot alibaba dot com, gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Mon, 12 Nov 2018 10:06:49 +0800
Subject: Re: [PATCH PR84648]Adjust loop exit conditions for loop-until-wrap cases.
References: <41044492-d88d-4b02-804e-bbc76465457d.bin.cheng@linux.alibaba.com> <20181111122032.38b0fa1c@nbbrfq.loc>

On Sun, Nov 11, 2018 at 7:20 PM Bernhard Reutner-Fischer
<rep.dot.nop@gmail.com> wrote:
>
> On Sun, 11 Nov 2018 16:02:33 +0800
> "bin.cheng" <bin.cheng@linux.alibaba.com> wrote:
>
> Quick observation unrelated to the real patch.
>
> I think the coding style mandates to use the type itself and not the
> underlying structure.
>
> I know there are alot of places from before our switch to C++ that
> still use enum tree_code or enum machine_mode, but new code should
> adhere to the style please.
>
> So: s/enum tree_code/tree_code/g
Thanks very much for reminding, I forgot the switch when writing the
patch, will update along with changes for other reviews.

Thanks,
bin
>
> thanks,

References:
- [PATCH PR84648]Adjust loop exit conditions for loop-until-wrap cases.
  - From: bin.cheng
- Re: [PATCH PR84648]Adjust loop exit conditions for loop-until-wrap cases.
  - From: Bernhard Reutner-Fischer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]