This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Restore -fopt-info-vec optimized locations for SLP vectorization
On Tue, 6 Nov 2018, David Malcolm wrote:
> On Tue, 2018-11-06 at 13:12 +0100, Richard Biener wrote:
> > The following patch pushes a DUMP_VECT_SCOPE down one level because
> > it otherwise hides a MSG_OPTIMIZED_LOCATION print.
> >
> > David - was this an intended effect of the scoping?
>
> No, an accident, sorry. The scope depth thing controlling
> MSG_PRIORITY_{USER_FACING|INTERNALS} is something of a blunt hammer.
>
> Thanks for fixing it.
>
> Am I right in thinking that we don't yet have any test coverage of
> -fopt-info-vec-optimized for SLP? (otherwise presumably my testing
> would have caught this)
Yes, looks like we only have a testcase for loop vectorization. BB
vectorization also doesn't yet use the opt-problem thing it seems.
> (FWIW, I'm working on -fopt-info-inline; I hope to post patches for
> that in the next day or so)
Great!
Richard.
> Dave
>
> > Applied to trunk.
> >
> > Richard.
> >
> > 2018-11-06 Richard Biener <rguenther@suse.de>
> >
> > * tree-vect-slp.c (vect_slp_bb): Move opening of
> > vect_slp_analyze_bb
> > dump-scope ...
> > (vect_slp_analyze_bb_1): ... here to avoid hiding optimized
> > locations.
> >
> > diff --git a/gcc/tree-vect-slp.c b/gcc/tree-vect-slp.c
> > index e7e5d252c00..f802b004bef 100644
> > --- a/gcc/tree-vect-slp.c
> > +++ b/gcc/tree-vect-slp.c
> > @@ -2779,6 +2779,8 @@ vect_slp_analyze_bb_1 (gimple_stmt_iterator
> > region_begin,
> > vec<data_reference_p> datarefs, int n_stmts,
> > bool &fatal, vec_info_shared *shared)
> > {
> > + DUMP_VECT_SCOPE ("vect_slp_analyze_bb");
> > +
> > bb_vec_info bb_vinfo;
> > slp_instance instance;
> > int i;
> > @@ -2949,8 +2951,6 @@ vect_slp_bb (basic_block bb)
> > bool any_vectorized = false;
> > auto_vector_sizes vector_sizes;
> >
> > - DUMP_VECT_SCOPE ("vect_slp_analyze_bb");
> > -
> > /* Autodetect first vector size we try. */
> > current_vector_size = 0;
> > targetm.vectorize.autovectorize_vector_sizes (&vector_sizes);
>
>
--
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)