This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, regrename] Fix PR87330 : ICE in scan_rtx_reg, at regrename.c
- From: Sameera Deshpande <sameera dot deshpande at linaro dot org>
- To: Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Cc: ebotcazou at adacore dot com, James Greenhalgh <james dot greenhalgh at arm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, vmakarov at redhat dot com, bergner at vnet dot ibm dot com, zadeck at naturalbridge dot com, Seongbae Park <seongbae dot park at gmail dot com>
- Date: Tue, 30 Oct 2018 16:30:55 +0530
- Subject: Re: [Patch, regrename] Fix PR87330 : ICE in scan_rtx_reg, at regrename.c
- References: <CAAdirjzj2+Zg2frrZJG8gd4O4urZRWFy9kqJ90CPA8inpq0hbQ@mail.gmail.com> <2731756.rRBjapG4av@polaris> <CAAdirjxGsN5SiZeB==AmXFykYL-Pui4r+9fBNrgGw9E=y7zJ0A@mail.gmail.com> <56b2486b-484c-cbb0-f367-e3b6761e16b6@arm.com>
On Tue, 30 Oct 2018 at 16:16, Richard Earnshaw (lists)
<Richard.Earnshaw@arm.com> wrote:
>
> On 30/10/2018 10:09, Sameera Deshpande wrote:
> > On Tue, 9 Oct 2018 at 04:08, Eric Botcazou <ebotcazou@adacore.com> wrote:
> >>
> >>> Other notes need not be changed, as they don't hold renamed register
> >>> information.
> >>>
> >>> Ok for trunk?
> >>
> >> No, REG_DEAD & REG_UNUSED note must be recomputed by passes consuming them.
> >>
> >>> 2018-10-09 Sameera Deshpande <sameera.deshpande@linaro.org
> >>>
> >>> * gcc/regrename.c (regrename_do_replace): Add condition to alter
> >>> regname if note has same register marked dead in notes.
> >>
> >> No gcc/ prefix in gcc/ChangeLog.
> >>
> >> --
> >> Eric Botcazou
> >
> > Hi Eric,
> >
> > Thanks for your comments.
> >
> > Please find attached updated patch invoking data flow for updating the
> > REG_DEAD and REG_UNUSED notes.
> >
> > As this change is made in falkor specific file, adding James and
> > Richard for review.
> >
> > Ok for trunk?
> >
> > Changelog:
> >
> > 2018-10-30 Sameera Deshpande <sameera.deshpande@linaro.org
> >
> > * gcc/config/aarch64/falkor-tag-collision-avoidance.c
> > (execute_tag_collision_avoidance): Invoke df_note_add_problem to
> > recompute REG_DEAD and REG_UNUSED notes before analysis.
> >
>
> 'Call df_note_add_problem.' is enough.
>
> OK with that change.
>
> R.
>
> >
> > bug87330.patch
> >
> > diff --git a/gcc/config/aarch64/falkor-tag-collision-avoidance.c b/gcc/config/aarch64/falkor-tag-collision-avoidance.c
> > index fb6568f..4ca9d66 100644
> > --- a/gcc/config/aarch64/falkor-tag-collision-avoidance.c
> > +++ b/gcc/config/aarch64/falkor-tag-collision-avoidance.c
> > @@ -805,6 +805,7 @@ execute_tag_collision_avoidance ()
> > df_set_flags (DF_RD_PRUNE_DEAD_DEFS);
> > df_chain_add_problem (DF_UD_CHAIN);
> > df_compute_regs_ever_live (true);
> > + df_note_add_problem ();
> > df_analyze ();
> > df_set_flags (DF_DEFER_INSN_RESCAN);
> >
> >
>
Thanks Richard! Patch committed at revision 265618.
--
- Thanks and regards,
Sameera D.