This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] bring netbsd/arm support up to speed. eabi, etc.
Thanks for the detailed response.
Sorry to give only a partial reply.
On Tue, Oct 23, 2018 at 02:36:57PM +0100, Richard Earnshaw (lists) wrote:
> Thanks for posting this. Before we can commit it, however, we need to
> sort out the authorship and ensure that all the appropriate copyright
> assignments are in place. Are you the sole author, or are other NetBSD
> developers involved?
The authors of these patches to netbsd are:
- matt thomas
- nick hudson
- matthew green
They are all listed in MAINTAINERS files in FSF projects so I think they
have a copyright assignment on file.
Matt Thomas is unresponsive lately but I can ask someone to bug him in
person.
> > +/* Default to full VFP if -mhard-float is specified. */
> > +#undef SUBTARGET_ASM_FLOAT_SPEC
> > +#define SUBTARGET_ASM_FLOAT_SPEC \
> > + "%{mhard-float:%{!mfpu=*:-mfpu=vfp}} \
> > + %{mfloat-abi=hard:%{!mfpu=*:-mfpu=vfp}}"
>
> Please rework this to use -mfpu=auto. -mfpu=vfp is very rarely the
> right setting to use.
This change seems scary. Going over my default CPUs, I guess the
problematic one might cortex-a8.
I'm worried it might have negative repercussions for VFPv3-d16.
Is that a valid concern?
I see generic-armv7-a is a more popular default CPU, but I am not sure
from reading the code that it avoids this problem.
Thanks.