This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Reset insn priority after inc/ref replacement in haifa sched
- From: Jeff Law <law at redhat dot com>
- To: Robin Dapp <rdapp at linux dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 10 Oct 2018 12:57:31 -0600
- Subject: Re: [PATCH] Reset insn priority after inc/ref replacement in haifa sched
- References: <d525a5d9-3948-563d-9afc-3a0dcbee4c25@linux.ibm.com>
On 10/10/18 10:03 AM, Robin Dapp wrote:
> Hi,
>
> as my last message
> (https://gcc.gnu.org/ml/gcc-patches/2018-10/msg00280.html) did not
> garner much attention, I'm posting it in proper patch form this time.
> The problem I'm trying to solve is that an insn's priority seems
> unchanged if the priority of insns that depend on it is changed (and the
> first insn's priority was computed by on of these dependent insns'
> priority). If I missed something or there is another way this should be
> working, I'd like to learn about that.
>
> A non-bootstrapped test suite run on s390 showed no regressions and an
> x86 one is currently running (current HEAD didn't bootstrap for me on
> x86). The actual code changes throughout SPEC2006 are minor and the
> performance impact is negligible provided we do not hit a fixable bad
> case as described in my last message.
>
> Regards
> Robin
>
> --
>
> gcc/ChangeLog:
>
> 2018-10-10 Robin Dapp <rdapp@linux.ibm.com>
>
> * haifa-sched.c (apply_replacement):
> Reset insn priority after inc/ref replacement.
>
See my last message. I find myself wondering if we need to reset
INSN_PRIORITY_STATUS in update_insn_after_change and/or calling
update_insn_after_change on INSN in additional to calling it on DESC->insn.
jeff