This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, AArch64 08/11] aarch64: Add out-of-line functions for LSE atomics

From: Florian Weimer <fweimer at redhat dot com>
To: rth7680 at gmail dot com
Cc: gcc-patches at gcc dot gnu dot org, ramana dot radhakrishnan at arm dot com, agraf at suse dot de, matz at suse dot de, Richard Henderson <richard dot henderson at linaro dot org>
Date: Wed, 26 Sep 2018 10:59:37 +0200
Subject: Re: [PATCH, AArch64 08/11] aarch64: Add out-of-line functions for LSE atomics
References: <20180926050355.32746-1-richard.henderson@linaro.org> <20180926050355.32746-9-richard.henderson@linaro.org>

* rth:

> diff --git a/libgcc/config/aarch64/lse.c b/libgcc/config/aarch64/lse.c
> new file mode 100644
> index 00000000000..20f4bde741f
> --- /dev/null
> +++ b/libgcc/config/aarch64/lse.c

> +static void __attribute__((constructor))
> +init_have_atomics(void)
> +{
> +  unsigned long hwcap = getauxval(AT_HWCAP);
> +  __aa64_have_atomics = (hwcap & HWCAP_ATOMICS) != 0;
> +}

Is there an expectation that it is possible to use the atomics in IFUNC
resolvers?  Then this needs an explanation why it is safe to run with
the other kind of atomics until the initialization of
__aa64_have_atomics has happened.

(GNU style requires a space before a parenthesis, at least in a function
call or function declarator.)

Thanks,
Florian

Follow-Ups:
- Re: [PATCH, AArch64 08/11] aarch64: Add out-of-line functions for LSE atomics
  - From: Richard Henderson

References:
- [PATCH, AArch64 00/11] LSE atomics out-of-line
  - From: rth7680
- [PATCH, AArch64 08/11] aarch64: Add out-of-line functions for LSE atomics
  - From: rth7680

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]