This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libgo patch committed: Update to 1.11 release


On Tue, Sep 25, 2018 at 1:03 AM, Andreas Schwab <schwab@suse.de> wrote:
> ../../../libgo/go/internal/cpu/cpu.go:21:16: error: reference to undefined name ‘CacheLineSize’
> 21 |  _            [CacheLineSize]byte
>    |                ^
> ../../../libgo/go/internal/cpu/cpu.go:38:16: error: reference to undefined name ‘CacheLineSize’
> 38 |  _            [CacheLineSize]byte
>    |                ^
> ../../../libgo/go/internal/cpu/cpu.go:51:14: error: reference to undefined name ‘CacheLineSize’
> 51 |  _          [CacheLineSize]byte
>    |              ^
> ../../../libgo/go/internal/cpu/cpu.go:63:14: error: reference to undefined name ‘CacheLineSize’
> 63 |  _          [CacheLineSize]byte
>    |              ^
> ../../../libgo/go/internal/cpu/cpu.go:71:15: error: reference to undefined name ‘CacheLineSize’
> 71 |  _           [CacheLineSize]byte
>    |               ^
> ../../../libgo/go/internal/cpu/cpu.go:96:15: error: reference to undefined name ‘CacheLineSize’
> 96 |  _           [CacheLineSize]byte
>    |               ^
> ../../../libgo/go/internal/cpu/cpu.go:102:19: error: reference to undefined name ‘CacheLineSize’
> 102 |  _               [CacheLineSize]byte
>     |                   ^
> ../../../libgo/go/internal/cpu/cpu.go:119:19: error: reference to undefined name ‘CacheLineSize’
> 119 |  _               [CacheLineSize]byte
>     |                   ^

Thanks for the various reports and sorry for the breakage.

I believe this patch will fix the three problems reported by Andreas.

In internal/bytealg correct a +build tag to never build
indexbyte_generic.go for gccgo, where we always use
indexbyte_native.go.

For internal/cpu let the Makefile define CacheLineSize using
goarch.sh, rather than trying to enumerate all the possibilities in
cpu_ARCH.go files.

In internal/poll call the C fcntl function rather than using
SYS_FCNTL.  Change mksysinfo.sh to ensure that F_GETPIPE_SZ is always
defined, and check that in internal/poll.

Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.  Committed
to mainline.

Ian

Attachment: patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]