This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call
On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> >> >> PING.
>> >> >
>> >> > Hi, Jan Uros,
>> >> >
>> >> > Can you review this patch?
>> >>
>> >> I don't know CET stuff, so I'm not able to review functionality of CET patches.
>> >
>> > My (very partial) understanding is that ENDBR is used to mark places where one
>> > can jump/call. So we need to always arrange it first. Normally this is done
>> > simply by inserting it very first in the instruction stream, but in cases
>> > where profiling code is inserted this breaks because profiling code is
>> > output as string rather than real instructions because it needs the code label
>> > to be referred from mloc_count section.
>> >
>> > It is ugly, I wonder how much work would be tu turn profiler insertion to also
>> > use RTL representation?
>> >
>>
>> We will investigate it.
> Thanks, do we need to backport this fix into release braches?
> (I think current patch is more suitable for backporting)
Yes, we need to backport it to GCC 8 branch.
--
H.J.