This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Update vec_splat references in testcases for validity.
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Will Schmidt <will_schmidt at vnet dot ibm dot com>
- Cc: David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 21 Sep 2018 09:33:54 -0500
- Subject: Re: [PATCH, rs6000] Update vec_splat references in testcases for validity.
- References: <1537469575.19375.24.camel@brimstone.rchland.ibm.com>
Hi Will,
On Thu, Sep 20, 2018 at 01:52:55PM -0500, Will Schmidt wrote:
> This updates those powerpc testsuite tests that are using the
> vec_splat() builtin with an invalid arg1. Per discussions during the
> review of gimple-folding for vec_splat(), it was clarified
> that arg1 for vec_splat() should be a valid index into the
> referenced vector (no modulo).
> 2018-11-20 Will Schmidt <will_schmidt@vnet.ibm.com>
>
> * gcc.target/powerpc/fold-vec-splat-char.c: Remove invalid
> vec_splat calls from recently added tests. Update instruction counts.
(Two spaces after dot.)
> * gcc.target/powerpc/fold-vec-splat-floatdouble.c: Same.
> * gcc.target/powerpc/fold-vec-splat-int.c: Same.
> * gcc.target/powerpc/fold-vec-splat-pixel.c: Same.
> * gcc.target/powerpc/fold-vec-splat-short.c: Same.
> * g++.dg/ext/altivec-6.C: Updated vec_splat() calls.
"Update".
Other than those trivialities this looks fine to me. Okay for trunk.
Thank you!
Segher