This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 21/25] GCN Back-end (part 2/2).


On 12/09/18 16:32, Joseph Myers wrote:
+	case "$host" in
+	x86_64*-*-linux-gnu )
+		if test "$ac_res" != no; then
+			extra_programs="${extra_programs} gcn-run\$(exeext)"
+		fi

ac_res is a generic autoconf variable used by a lot of tests.  I don't
think it's at all safe to embed an assumption into the middle of
config.gcc about which the last test run that sets such a variable is; you
need a variable explicitly relating to whatever the relevant test is.

Oops, EWRONGPATCH. That's supposed to be "ac_cv_search_dlopen".

What if the host is x86_64 with the x32 ABI?  If the requirement is for
various types to be the same between the host and GCN, I'd expect that x32
ABI on the host means it is unsuitable for using gcn-run.  Or are the
requirements for compatible types between some other two pieces, so that
an x32 gcn-run is OK?

No, x32 would not be ok. The test as is rejects x86_64-*-linux-gnux32, so that ought not to be a problem unless somebody has an x32 system with the default triplet.

Is that something we really need to care about? If so then I guess a new configure test is needed.

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]