This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] [match.pd]: missing optimization on comparison


On Sun, 2 Sep 2018, Bernhard Reutner-Fischer wrote:

On 30 August 2018 22:20:06 CEST, Marc Glisse <marc.glisse@inria.fr> wrote:
Hello,


INTEGRALS_SIGN_PREC_MATCH: the name doesn't really match the semantics.

+#define INTEGRALS_SIGN_PREC_MATCH(A, B) \
+  TYPE_PRECISION (TREE_TYPE (A)) == TYPE_PRECISION (TREE_TYPE (B)) \
+  (TYPE_PRECISION (TREE_TYPE (A)) > TYPE_PRECISION (TREE_TYPE (B)) \
+   && !TYPE_UNSIGNED (TREE_TYPE (B)))
+

Unless my mailer somehow mangled it, isn't there some operator ( maybe || ?) missing between the eq clause and the second one?

Kai sent a second email immediately afterwards that fixes this.

--
Marc Glisse


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]