This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING 5][PATCH] [v4][aarch64] Avoid tag collisions for loads falkor


On Wednesday 29 August 2018 10:05 PM, James Greenhalgh wrote:
Sorry that this took me so long to get to. > > The code is outstanding quality, a textbook example of writing an
> analysis/optimization pass using modern GCC frameworks and data > structures! If you ever find the opportunity, I bet you could create > some useful newcomer training materials from this source. > > This is almost OK for trunk, please just clean up the (very few) > issues detected by check_GNU_style.py and make the obvious rebase on > trunk. As I know you will ask, you can also backport to GCC 8 if you > are happy with that risk for the Falkor subtarget. Thanks for the very generous review :)  I'll fix it up and push it next week when I return from my holiday.

Cheers,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]