This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GCC][AARCH64] Use stdint integers in vect_su_add_sub.c
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Matthew Malcomson <Matthew dot Malcomson at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, nd <nd at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, "kyrylo dot tkachov at foss dot arm dot com" <kyrylo dot tkachov at foss dot arm dot com>, "christophe dot lyon at linaro dot org" <christophe dot lyon at linaro dot org>
- Date: Tue, 28 Aug 2018 23:15:30 +0100
- Subject: Re: [PATCH][GCC][AARCH64] Use stdint integers in vect_su_add_sub.c
- References: <HE1PR0801MB20117E61A84DC2AAE528651EE02C0@HE1PR0801MB2011.eurprd08.prod.outlook.com> <20180802191801.GB38486@arm.com> <2dc9f574-ef82-32da-d8e2-459c46caa255@arm.com>
On Fri, Aug 03, 2018 at 11:28:08AM -0500, Matthew Malcomson wrote:
> On 02/08/18 20:18, James Greenhalgh wrote:
> > On Tue, Jul 31, 2018 at 04:53:19AM -0500, Matthew Malcomson wrote:
> >> Fixing the ilp32 issue that Christophe found.
> >>
> >> The existing testcase uses `long` to represent a 64 bit integer.
> >> This breaks when compiled using the `-mabi=ilp32` flag.
> >> We switch the use of int/long for int32_t/int64_t to avoid this problem
> >> and show the requirement of a widening operation more clearly.
> > Normally we try to avoid pulling more headers than we need in the testsuite.
> >
> > Have you seen this construct:
> >
> > typedef unsigned __attribute__((mode(DI))) uint64_t;
> >
> > It can be a good way to ensure you have the right type for the patterns you
> > are adding.
> >
> > Thanks,
> > James
> Thanks! No I hadn't seen that construct before.
> Have attached a patch using that construct.
OK.
Thanks,
James