This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Come up with TARGET_GET_VALID_OPTION_VALUES option hook (PR driver/83193).
- From: Martin Liška <mliska at suse dot cz>
- To: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- Cc: "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>, Thomas Preudhomme <thomas dot preudhomme at linaro dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, James Greenhalgh <james dot greenhalgh at arm dot com>, Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, Richard Biener <richard dot guenther at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Mon, 27 Aug 2018 12:00:50 +0200
- Subject: Re: [PATCH] Come up with TARGET_GET_VALID_OPTION_VALUES option hook (PR driver/83193).
- References: <ccd3548b-d582-0fdd-b37a-d56a651d23bb@suse.cz> <6910f5f6-f898-fd8b-c035-35fc0197c3c8@suse.cz> <9f99cc79-8d31-ea53-b265-7d7bdd58d6c2@arm.com> <8ee3b08e-88af-3ff9-dcb9-e74088f0180b@suse.cz> <ab4c2148-5576-65e3-f297-a53526bb47d5@arm.com> <7f176f43-3d32-200f-ec29-66e79a005675@suse.cz> <05f00a6a-118a-5646-7289-78657f05cdf0@arm.com> <b12f3b96-ffb8-f984-0d6a-f145a5f1ad94@suse.cz> <adaa84a3-2056-0361-5383-e9851d4bd1ae@arm.com> <92ef5b1f-ac9e-5218-53fd-dcb322eac7b0@suse.cz> <215f6b4d-6209-60e3-8180-15585ffe7a7d@arm.com> <05c01c34-127f-9bb2-82f6-0fe80adffbe6@suse.cz> <b26d14df-1d65-971f-c144-a80c34aa352b@arm.com> <88a87380-8820-0a4f-d9f2-4912447e86bc@suse.cz> <2319e77b-9be2-d3b2-44bb-de74a6575423@arm.com> <0fa8f693-0860-4a52-c9d5-679627b6b70d@suse.cz> <f57453d8-f505-e163-0a65-b64e8a6cbf5f@suse.cz> <e58c9960-9172-14d1-c470-cb97bdd61f94@suse.cz> <CAJA7tRbj9UPigORDXKAjjFTcFrZ6i8+QHUupMXr4j7jhdAn9UQ@mail.gmail.com> <10cbcfb7-0773-53ad-6f12-517a07c8879f@suse.cz>
On 08/13/2018 03:00 PM, Martin Liška wrote:
> On 08/13/2018 02:54 PM, Ramana Radhakrishnan wrote:
>> On Mon, Aug 13, 2018 at 1:49 PM, Martin Liška <mliska@suse.cz> wrote:
>>> PING^1
>>>
>>> On 07/24/2018 02:05 PM, Martin Liška wrote:
>>>> Hi.
>>>>
>>>> I'm sending updated version of the patch. It comes up with a new target common hook
>>>> that provide option completion list. It's used both in --help=target and with --completion
>>>> option. I implemented support for -match and -mtune for i386 target.
>>>>
>>>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
>>
>> Err I don't maintain the x86 backend to review this effectively. In an
>> ideal world you would have split this into 2 patches 1 for the common
>> parts and 1 for x86 and CC'd the relevant x86 maintainers. I'm not
>> clear what you are looking for here from me :-/
>
> Sorry, I was not clear. I would like to hear from ARM's folks that interface
> design is fine for them? I know a global reviewer will have to approve that.
I'm CC'ing Jakub and Richard who can help us with the new target hook infrastructure.
Martin
>
> Martin
>
>>
>> Ramana
>>>>
>>>> Martin
>>>>
>>>
>