This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][RFC] Add gimple-cfg.h.


On Mon, Aug 27, 2018 at 9:13 AM Martin Liška <mliska@suse.cz> wrote:
>
> Hi.
>
> There's updated version with notes that were discussed with Richi
> on IRC. As pointed out label_to_block can potentially lead to
> quadratic complexity, but it's not ambition of the patch to resolve
> that.

Please don't

@@ -3239,7 +3239,7 @@ expand_asm_stmt (gasm *stmt)
             may insert further instructions into the same basic block after
             asm goto and if we don't do this, insertion of instructions on
             the fallthru edge might misbehave.  See PR58670.  */
-         if (fallthru_bb && label_to_block_fn (cfun, label) == fallthru_bb)
+         if (fallthru_bb && label_to_block (label) == fallthru_bb)
            {
              if (fallthru_label == NULL_RTX)
                fallthru_label = gen_label_rtx ();

rather the label_to_block function should go away.  OK with removing any
such instances in the patch.

Richard.

> Martin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]