This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Fix PR86731 vec_sl()


Hi!

On Tue, Aug 14, 2018 at 06:18:28PM -0500, Will Schmidt wrote:
> 	PR target/86731
> 	* config/rs6000/rs6000.c (rs6000_gimple_fold_builtin): Update logic
> 	  around folding of vec_sl() to handle out of range shift values.

Shouldn't indent continuation lines in changelog.

> +      {
> +	location_t loc;
> +	gimple_seq stmts = NULL;
> +	arg0 = gimple_call_arg (stmt, 0);
> +	tree arg0_type = TREE_TYPE (arg0);
> +	if (INTEGRAL_TYPE_P (TREE_TYPE (arg0_type))
> +			&& !TYPE_OVERFLOW_WRAPS (TREE_TYPE (arg0_type)))
> +		return false;

	if (INTEGRAL_TYPE_P (TREE_TYPE (arg0_type))
	    && !TYPE_OVERFLOW_WRAPS (TREE_TYPE (arg0_type)))
	  return false;

> +/* { dg-final { scan-assembler-times {\mvspltisb\M|\mvspltish\M|\mvspltisw\M} 7 } } */

Maybe you want
/* { dg-final { scan-assembler-times {\mvspltis[bhw]\M} 7 } } */
instead?

Rest looks fine to me (whatever that means :-) )


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]