This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PR 87073] [committed] fix go bootstrap

From: Aldy Hernandez <aldyh at redhat dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 24 Aug 2018 13:05:58 -0400
Subject: Re: [PR 87073] [committed] fix go bootstrap
References: <ba4cd00c-9a13-b33b-ee3b-5531e54db31d@redhat.com> <CAMe9rOpeOUMmX1nrfMPnrDm4JWJ_AVrPv2NzpFczNFoC_cUWSA@mail.gmail.com>



On 08/24/2018 12:56 PM, H.J. Lu wrote:

n Fri, Aug 24, 2018 at 1:02 AM Aldy Hernandez <aldyh@redhat.com> wrote:


I have no idea how this passed bootstrap and tests in other languages.

The problem here is that wide_int_binop is overflowing on TRUNC_DIV_EXPR
and a range in Go.  This is causing us to use wmin/wmax uninitialized.

Serves me right for all my whining about Ada yesterday.  I think the VRP
changes are sufficiently all encompassing that I will start testing
--enable-languages=all instead of whatever our defaults are.  My bad.

Committed as obvious.


This patch also fixed:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87092

I am checking in this patch to add a testcase.


Thank you.

References:
- [PR 87073] [committed] fix go bootstrap
  - From: Aldy Hernandez
- Re: [PR 87073] [committed] fix go bootstrap
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]