This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] DWARF: Call set_indirect_string on DW_MACINFO_start_file
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: "H. J. Lu" <hjl dot tools at gmail dot com>
- Cc: Mark Wielaard <mjw at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, ccoutant at gmail dot com
- Date: Fri, 24 Aug 2018 11:02:39 +0200
- Subject: Re: [PATCH] DWARF: Call set_indirect_string on DW_MACINFO_start_file
- References: <20180822193624.GA22426@intel.com> <CAFiYyc3KxSsZh5H-R=rTaTNHwsjpWprSPFvgVr-1zzDHXT6q1g@mail.gmail.com> <CAMe9rOrL89r4aoHao5QSvxU2gwiGDFs5RZTEETx6Gy5NdzC2fw@mail.gmail.com>
On Thu, Aug 23, 2018 at 4:38 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Thu, Aug 23, 2018 at 5:56 AM, Richard Biener
> <richard.guenther@gmail.com> wrote:
> > On Wed, Aug 22, 2018 at 9:36 PM H.J. Lu <hongjiu.lu@intel.com> wrote:
> >>
> >> Since -gsplit-dwarf -g3 will output filename as indirect string, call
> >> set_indirect_string on DW_MACINFO_start_file for -gsplit-dwarf -g3.
> >>
> >> OK for trunk?
> >
> > Can you add a testcase?
> >
> >
>
> Here is the updated patch with a testcase. Before my fix:
>
> /export/build/gnu/tools-build/gcc-debug/build-x86_64-linux/gcc/xgcc
> -B/export/build/gnu/tools-build/gcc-debug/build-x86_64-linux/gcc/ -m32
> -O2 -fno-var-tracking-assignments -gsplit-dwarf -g3 -march=skylake
> -mrtm -mabm -S x.c
> x.c:14:1: internal compiler error: in output_index_string, at dwarf2out.c:28780
> 14 | }
> | ^
> 0xb090e7 output_index_string(indirect_string_node**, unsigned int*)
> /export/gnu/import/git/sources/gcc/gcc/dwarf2out.c:28780
> 0xb09370 output_indirect_strings
> /export/gnu/import/git/sources/gcc/gcc/dwarf2out.c:28868
> 0xb0ed85 dwarf2out_finish
> /export/gnu/import/git/sources/gcc/gcc/dwarf2out.c:31563
> Please submit a full bug report,
> with preprocessed source if appropriate.
> Please include the complete backtrace with any bug report.
> See <https://gcc.gnu.org/bugs/> for instructions.
>
> After:
>
> /export/build/gnu/tools-build/gcc-debug/build-x86_64-linux/gcc/xgcc
> -B/export/build/gnu/tools-build/gcc-debug/build-x86_64-linux/gcc/ -m32
> -O2 -fno-var-tracking-assignments -gsplit-dwarf -g3 -march=skylake
> -mrtm -mabm -S x.c
>
> OK for trunk?
OK.
Richard.
> Thanks.
>
> --
> H.J.