This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH] Make function clone name numbering independent.
- From: Jeff Law <law at redhat dot com>
- To: Michael Ploujnikov <michael dot ploujnikov at oracle dot com>, Richard Biener <richard dot guenther at gmail dot com>
- Cc: Bernhard Fischer <rep dot dot dot nop at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, hubicka at ucw dot cz, Sriraman Tallam <tmsriram at google dot com>
- Date: Mon, 20 Aug 2018 13:47:37 -0600
- Subject: Re: [PING][PATCH] Make function clone name numbering independent.
- References: <a8a7ea06-98f3-1b7c-d0bb-4e428cb97cf3@oracle.com> <6A1E6E88-63F7-43E4-8A53-78C7694D34BE@gmail.com> <CAFiYyc1Vcbx7NQBLAbTLrQmFmdOTCX_PrzuLf4CJ9KnKzJSHTQ@mail.gmail.com> <069cb2a6-2e37-58fb-2009-35e0300270f1@oracle.com> <618e046e-3f28-f008-237d-497bcff2531e@oracle.com> <CAFiYyc3fgCkaF0=XvzSDnLoM47a2OgAn0PA8x8Xm3zPJ-D1v-Q@mail.gmail.com> <121c01f4-c1a2-249e-2cac-c6d5ec250fcb@oracle.com> <702ab3f1-fe25-9013-7a1e-f5e1615c9396@oracle.com> <85bd8119-0bce-a06d-df3f-1a1a6ed88187@oracle.com> <CAFiYyc0bF72pX8rr4krbxi6RmKn8VyzKz7VyTEAAeQQJyKXoFQ@mail.gmail.com> <bfd6145a-d8f0-1fa9-5375-77e4e314bcd3@oracle.com> <3167e521-aa5b-e47c-6d9b-956a1af2a886@oracle.com>
On 08/13/2018 05:58 PM, Michael Ploujnikov wrote:
> Ping and I've updated the patch since last time as follows:
>
> - unittest scans assembly rather than the constprop dump because its
> forward changed
> - unittests should handle different hosts where any of
> NO_DOT_IN_LABEL, NO_DOLLAR_IN_LABEL or __USER_LABEL_PREFIX__ may
> be defined
> - not 100% it's safe to change DECL_NAME to DECL_ASSEMBLER_NAME in
> cgraph_node::create_virtual_clone, but I've attempted to reduce
> some code duplication
> - lto-partition.c: privatize_symbol_name_1 *does* need numbered
> names
> - but cold sections don't
> - Expecting an IDENTIFIER_NODE in clone_function_name_1 avoids
> unreliable string pointer use as pointed out in the first review
> - renamed clone_function_name_1 and clone_function_name to
> numbered_clone_function_name_1 and numbered_clone_function_name to
> clarify purpose and discourage future unintended uses
Richi has more state here than I do, so I'm going to let him own it. I
know he's just returning from PTO, so it's going to take him a bit of
time to catch up.
jeff