This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, testsuite] Fix PR78544 for Darwin.


> On 15 Aug 2018, at 19:39, Mike Stump <mikestump@comcast.net> wrote:
> 
> On Aug 15, 2018, at 6:20 AM, Iain Sandoe <iain@sandoe.co.uk> wrote:
>> 
>> The fails on Darwin are because the section naming convention is different.
>> 
>> The patch adds Darwin-specific section attributes and a corresponding target-specific scan-assembler clause.
>> 
>> OK for trunk?
>> affected branches (7, 8)?
> 
> Ok.
> 
> [ just thinking out loud ] It might be nice to have a section name mapper that can convert section names from the rest of the world, into Darwin style section names.  .text -> __TEXT,__text and so on, then some of this patch can be backed out as unnecessary. The point of the patch would be to increase the portability of code to the platform.  The other possibility would be for darwin to just add support for all the usual elf things and for those all to work.

It’s a good thought - we quite frequently end up fixing “bugs” that are just folks forgetting to add the Darwin-flavour section.

One of my Grand Ideas (i.e. things that might never happen because of time) would be to split out the Well Known Sections used by GCC into file/files with .defs for the different flavours. This would mean one place to add a new GCC named section - which would make it much less likely for folks to forget to add the Darwin ones (assuming there are no targets left without named sections).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]