This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH to implement C++20 P0806R2, Deprecate implicit capture of this via [=]


On Sun, Aug 12, 2018 at 3:53 PM, Marek Polacek <polacek@redhat.com> wrote:
> -      var = add_capture (lambda,
> -                            id,
> -                            initializer,
> -                            /*by_reference_p=*/
> -                           (this_capture_p
> -                            || (LAMBDA_EXPR_DEFAULT_CAPTURE_MODE (lambda)
> -                                == CPLD_REFERENCE)),
> -                           /*explicit_init_p=*/false);
> +      var = add_capture (lambda, id, initializer,
> +                        /*by_reference_p=*/
> +                        (this_capture_p
> +                         || (LAMBDA_EXPR_DEFAULT_CAPTURE_MODE (lambda)
> +                             == CPLD_REFERENCE)),
> +                        /*explicit_init_p=*/false);

This reformatting seems unnecessary, and I prefer to avoid unnecessary
reformatting to avoid noise in 'git blame'. The rest of the patch is
OK.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]