This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Diagnostic included-from loop
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Nathan Sidwell <nathan at acm dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 06 Aug 2018 11:57:46 -0400
- Subject: Re: [PATCH] Diagnostic included-from loop
- References: <1664468a-4474-5466-df05-dd4520fa08af@acm.org>
On Mon, 2018-08-06 at 11:32 -0400, Nathan Sidwell wrote:
> We currently emit the 'included from' information in a peeled-once
> loop.
> This patch rerolls the loop. It'll make some future changes
> simpler,
> and we're not at all worried about speed here -- it's a diagnostic!
>
> In the long term, the include-at path will include modules (imported
> at). Having single logic to figure that out is simpler.
>
> In the near future, I have a patch to change the representation of
> the
> included-from information, which I'll get to shortly.
>
> ok?
>
> nathan
I believe the only functional change here is that the strings are now
marked for translation, and translated.
OK for trunk, assuming you performed the usual testing on this patch.
Dave