This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2 7/7] Enable clobber high for tls descs on Aarch64
- From: Richard Sandiford <richard dot sandiford at arm dot com>
- To: Alan Hayward <alan dot hayward at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, nd at arm dot com
- Date: Mon, 06 Aug 2018 14:15:39 +0100
- Subject: Re: [PATCH v2 7/7] Enable clobber high for tls descs on Aarch64
- References: <20180726091329.26875-1-alan.hayward@arm.com> <20180726091329.26875-8-alan.hayward@arm.com>
Alan Hayward <alan.hayward@arm.com> writes:
> Add the clobber high expressions to tls_desc for aarch64.
> It also adds three tests.
>
> In addition I also tested by taking the gcc torture test suite and making
> all global variables __thread. Then emended the suite to compile with -fpic,
> save the .s file and only for one given O level.
> I ran this before and after the patch and compared the resulting .s files,
> ensuring that there were no ASM changes.
> I discarded the 10% of tests that failed to compile (due to the code in
> the test now being invalid C).
> I did this for O0,O2,O3 on both x86 and aarch64 and observed no difference
> between ASM files before and after the patch.
>
> Alan.
>
> 2018-07-25 Alan Hayward <alan.hayward@arm.com>
>
> gcc/
> * config/aarch64/aarch64.md: Add clobber highs to tls_desc.
>
> gcc/testsuite/
> * gcc.target/aarch64/sve_tls_preserve_1.c: New test.
> * gcc.target/aarch64/sve_tls_preserve_2.c: New test.
> * gcc.target/aarch64/sve_tls_preserve_3.c: New test.
Like you were saying off-line, these should be in the aarch64/sve/
directory. Files there don't specify an -march* option, since the
harness adds one if necessary.
OK with that change, thanks.
Richard