This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2] libitm: sh: avoid absolute relocation in shared library (PR 86712)
- From: Oleg Endo <oleg dot endo at t-online dot de>
- To: Jeff Law <law at redhat dot com>, slyfox at inbox dot ru, gcc-patches at gcc dot gnu dot org, Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Sergei Trofimovich <slyfox at gentoo dot org>, Torvald Riegel <triegel at redhat dot com>, Alexandre Oliva <aoliva at redhat dot com>, Oleg Endo <olegendo at gcc dot gnu dot org>, Kaz Kojima <kkojima at gcc dot gnu dot org>
- Date: Sat, 04 Aug 2018 18:00:39 +0900
- Subject: Re: [PATCH v2] libitm: sh: avoid absolute relocation in shared library (PR 86712)
- References: <87in4zbkh9.fsf@igel.home> <20180728130416.7730-1-slyfox@inbox.ru> <67f4e6b4-931a-6c4c-a9a7-25e1d65f7b75@redhat.com>
On Fri, 2018-08-03 at 14:54 -0600, Jeff Law wrote:
> On 07/28/2018 07:04 AM, slyfox.inbox.ru via gcc-patches wrote:
> >
> > From: Sergei Trofimovich <slyfox@gentoo.org>
> >
> > Cc: Andreas Schwab <schwab@linux-m68k.org>
> > Cc: Torvald Riegel <triegel@redhat.com>
> > Cc: Alexandre Oliva <aoliva@redhat.com>
> > Cc: Oleg Endo <olegendo@gcc.gnu.org>
> > Cc: Kaz Kojima <kkojima@gcc.gnu.org>
> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> > ---
> > libitm/config/sh/sjlj.S | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libitm/config/sh/sjlj.S b/libitm/config/sh/sjlj.S
> > index 043f36749be..f265ab8f898 100644
> > --- a/libitm/config/sh/sjlj.S
> > +++ b/libitm/config/sh/sjlj.S
> > @@ -53,7 +53,7 @@ _ITM_beginTransaction:
> > #else
> > cfi_def_cfa_offset (4*10)
> > #endif
> > -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__
> > +#if !defined __PIC__
> > mov.l .Lbegin, r1
> > jsr @r1
> > mov r15, r5
> > @@ -78,7 +78,7 @@ _ITM_beginTransaction:
> >
> > .align 2
> > .Lbegin:
> > -#if defined HAVE_ATTRIBUTE_VISIBILITY || !defined __PIC__
> > +#if !defined __PIC__
> > .long GTM_begin_transaction
> > #else
> > .long GTM_begin_transaction@PCREL-(.Lbegin0-.)
> >
> THanks. I installed this version.
>
Thanks Jeff.
If there are no objections, I'll backport it to the 7 and 8 branches.
Cheers,
Oleg