This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [aarch64][v2] Fix falkor pipeline description for dup<q>
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "kyrylo dot tkachov at foss dot arm dot com" <kyrylo dot tkachov at foss dot arm dot com>, <nd at arm dot com>
- Date: Thu, 2 Aug 2018 19:32:23 +0100
- Subject: Re: [PATCH] [aarch64][v2] Fix falkor pipeline description for dup<q>
- References: <20180802165837.23379-1-siddhesh@sourceware.org>
On Thu, Aug 02, 2018 at 11:58:37AM -0500, Siddhesh Poyarekar wrote:
> There was a typo in the pipeline description where DUP was assigned to
> the vector pipes for quad mode ops when it really only uses the VTOG
> pipes. Fixing this does not show any noticeable difference in
> performance (there's a very small bump of 1.7% in x264 but that's
> about it) in my tests but is the more precise description of operations
> for falkor.
>
> Bootstrapped and tested with --with-cpu=falkor to confirm that there
> are no regressions.
OK.
Thanks,
James
>
> Siddhesh
>
> Changes from v1:
>
> - Fixed up ChangeLog entry
>
> - Replaced falkor_gtov,falkor_gtov with falkor_gtov*2
>
> * config/aarch64/falkor.md (falkor_am_1_vxvy_vxvy): Move
> neon_dup_q to...
> (falkor_am_1_gtov_gtov): ... a new insn reservation.
>