This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR libstdc++/60555 std::system_category() should recognise POSIX errno values
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Thu, 2 Aug 2018 11:32:56 -0400
- Subject: Re: [PATCH] PR libstdc++/60555 std::system_category() should recognise POSIX errno values
Jonathan
This patch broke AIX bootstrap.
/nasfarm/edelsohn/src/src/libstdc++-v3/src/c++11/system_error.cc: In
member function 'virtual std::error_condition
{anonymous}::system_error_category::default_error_condition(int)
const':
/nasfarm/edelsohn/src/src/libstdc++-v3/src/c++11/system_error.cc:245:7:
error: duplicate case value
case ENOTEMPTY:
^~~~
/nasfarm/edelsohn/src/src/libstdc++-v3/src/c++11/system_error.cc:136:7:
note: previously used here
case EEXIST:
^~~~
AIX errno.h
/*
* AIX returns EEXIST where 4.3BSD used ENOTEMPTY;
* but, the standards insist on unique errno values for each errno.
* A unique value is reserved for users that want to code case
* statements for systems that return either EEXIST or ENOTEMPTY.
*/
#if defined(_ALL_SOURCE) && !defined(_LINUX_SOURCE_COMPAT)
#define ENOTEMPTY EEXIST /* Directory not empty */
#else /* not _ALL_SOURCE */
#define ENOTEMPTY 87
#endif /* _ALL_SOURCE */
I will add _LINUX_SOURCE_COMPAT and see how bootstrap proceeds. If it
works, it also will be required in the backport.
Thanks, David